r2323 broke Stencil Test - Printable Version

The following warnings occurred:

Warning [2] Undefined property: MyLanguage::$archive_pages - Line: 2 - File: printthread.php(287) : eval()'d code PHP 8.2.29 (Linux)

File	Line	Function
/inc/class_error.php	153	errorHandler->error
/printthread.php(287) : eval()'d code	2	errorHandler->error_callback
/printthread.php	287	eval
/printthread.php	117	printthread_multipage

r2323 broke Stencil Test - Printable Version

+- EmuNewz Network (https://www.emunewz.net/forum)
+-- Forum: PSP Emulation (https://www.emunewz.net/forum/forumdisplay.php?fid=191)
+--- Forum: JPCSP Official Forum (https://www.emunewz.net/forum/forumdisplay.php?fid=51)
+---- Forum: svn trunk discussion (https://www.emunewz.net/forum/forumdisplay.php?fid=56)
+---- Thread: r2323 broke Stencil Test (/showthread.php?tid=40334)

Pages: 1 2

RE: r2323 broke Stencil Test - nightflyer - 04-16-2012

I've been looking at the code and I'm pretty sure the problem is that this code is missing in setClearModeSettings in grapics\RE\BaseRenderingEngineFunction.java:
// Keep this test for non shader use.
// Certain games lack or incorrectly display graphics without this
// (e.g.: "Worms Open Warfare 2").
if (stencil) {
re.enableFlag(GU_STENCIL_TEST);
re.setStencilFunc(GeCommands.STST_FUNCTION_ALWAYS_PASS_STENCIL_TEST, 0, 0);
re.setStencilOp(GeCommands.SOP_KEEP_STENCIL_VALUE, GeCommands.SOP_KEEP_STENCIL_VALUE, GeCommands.SOP_ZERO_STENCIL_VALUE);
}

I'm not sure, but it might be that adding this code again is enough to fix theese issues with hardware rendering.

RE: r2323 broke Stencil Test - nightflyer - 04-17-2012

I tested adding the code from my last post to the latest revision I had(r2533) and the grapic problems I had with Valkyria Chronicles 3 - ULJM05781 dissapeared.
So could any of the devs that can commit to the repository add this code to setClearModeSettings in src\jpcsp\grapics\RE\BaseRenderingEngineFunction.java ?
I must admit that I don't fully understand this code(or the reason it was removed in r2323 in the first place) but I don't think there is a downside to having that code in there.

RE: r2323 broke Stencil Test - jacky400 - 04-17-2012

Thanks for the fix . hope sombody from dev can commit to our latest rev and we can test it against other games

RE: r2323 broke Stencil Test - gid15 - 04-17-2012

(04-17-2012, 09:58 AM)nightflyer Wrote: I tested adding the code from my last post to the latest revision I had(r2533) and the grapic problems I had with Valkyria Chronicles 3 - ULJM05781 dissapeared.
So could any of the devs that can commit to the repository add this code to setClearModeSettings in src\jpcsp\grapics\RE\BaseRenderingEngineFunction.java ?
I must admit that I don't fully understand this code(or the reason it was removed in r2323 in the first place) but I don't think there is a downside to having that code in there.

Thanks for your research!
I've commited the change in r2536 so that it can be tested by a larger base of testers. Please check different games in both shader and non-shader modes.

The stencil is/cannot be properly implemented in non-shader mode, so any fix is a kind of "find the least worst solution".

RE: r2323 broke Stencil Test - jacky400 - 04-17-2012

Confirmed this change fix the issue from super robot taisen z in both shader and non-shader mode

RE: r2323 broke Stencil Test - nightflyer - 04-17-2012

Thank you for fixing it gid15

RE: r2323 broke Stencil Test - legend80 - 04-18-2012

(04-17-2012, 09:15 PM)nightflyer Wrote: Thank you for fixing it gid15

You deserve the biggest thanks here!! Smile

Worms is all fixed up!

RE: r2323 broke Stencil Test - gid15 - 04-18-2012

(04-18-2012, 04:10 AM)legend80 Wrote: Worms is all fixed up!

Whaow, I was not expecting such positive results.

Good catch nightflyer!