Dissidia: Final Fantasy - ULUS10437

[gid15]

Starting with r1955, I'm getting graphical corruption (screen capture included in attachment) at the beginning of an EX Burst move in the tutorial battle. Also, when the guy says, "Intervene and be slain!" his mouth doesn't move. In r1954, his mouth moves during that line and also there's no corruption at the beginning of the EX Burst move.

The regression is due to the changes made in jpcsp.Allegrex.compiler.nativeCode.NativeCodeSequence and/or jpcsp.Allegrex.compiler.nativeCode.NativeCodeManager. From r1955, if I revert just those 2 files to r1954 and also revert the method call in jpcsp.Allegrex.compiler.CompilerContext, the game runs fine without the missing mouth movements and graphical corruption.

The regression still occurs in r1964 BTW.

UPDATE
Okay, I've found the problem. In r1964, class jpcsp.Allegrex.compiler.nativeCode.NativeCodeManager is missing a check condition in line 298. I think it should be:

if (opcode == 0 || !nativeCodeSequence.isMatching(i, opcode)) {

This fixes the missing mouth movements and graphical corruption.

Thanks!
The real problem has been fixed in r1968 (was located in jpcsp.Allegrex.compiler.nativeCode.graphics.sceGu.sceGuCopyImage)