10-16-2011, 04:36 PM
(10-16-2011, 01:45 PM)gid15 Wrote: I've reviewed again the code for the settings handling of "Handle SAVEDATA in crypto mode" and cannot find any problem, it should work like before. Could you do more testing, e.g. by adding a log in CryptoEngine.setSavedataCryptoStatus to check the value of the flag?
Okay, I think I've found the problem. In r2345, you registered the cryptSavedataSettingsListener in the constructor for CryptoEngine. The problem with that is if the game has already been decrypted and the CryptoEngine is not used during game load, that listener is never registered and therefore the emu.cryptoSavedata setting is always disabled. It needs to be put somewhere else where it will always be registered since the encrypted savedata setting is not dependent on whether the game's encrypted or not. This explains why that setting works in some of my games and not in others.
Oh, and thanks a lot for the other fixes!