+- EmuNewz Network (https://www.emunewz.net/forum)
+-- Forum: PSP Emulation (https://www.emunewz.net/forum/forumdisplay.php?fid=191)
+--- Forum: JPCSP Official Forum (https://www.emunewz.net/forum/forumdisplay.php?fid=51)
+---- Forum: svn trunk discussion (https://www.emunewz.net/forum/forumdisplay.php?fid=56)
+---- Thread: Unsupported bezier patches patch_div_s Fix (/showthread.php?tid=86019)
Unsupported bezier patches patch_div_s Fix - sum2012 - 10-07-2012
Code:
VideoEngine.java
private void drawBezier(int ucount, int vcount) {
if ((ucount - 1) % 3 != 0 || (vcount - 1) % 3 != 0) {
log.warn("Unsupported bezier parameters ucount=" + ucount + " vcount=" + vcount);
return;
}
if (context.patch_div_s <= 0 || context.patch_div_t <= 0) {
log.warn("Testing fix for Unsupported bezier patches patch_div_s=" + context.patch_div_s + " patch_div_t=" + context.patch_div_t); //change here
if (context.patch_div_s < 1){ context.patch_div_s = 1 ;}//change here
if (context.patch_div_t < 1){ context.patch_div_t = 1;}//change here
// return; //change here
}
initRendering();
...Second Novel Kanojo no Natsu 15 fun no Kioku Menu
Rev2758
http://imageshack.us/a/img141/1503/menubad.jpg
Rev2758 fixed version
http://imageshack.us/a/img715/8963/menuok.jpg
Hope apply the offical version.Thanks
Edit:Add log file
RE: Unsupported bezier patches patch_div_s Fix - digiadventures - 10-08-2012
Cant you add the code directly to google svn so that you version appears on buildbot.orphis.net for example ?
Or do you have to be aproved by gid15 fist ? I dont know how this works ?
RE: Unsupported bezier patches patch_div_s Fix - sum2012 - 10-08-2012
I don't know how to add the code directly to google svn.
I also don't know have to be aproved by gid15 fist.
Offical code do not render the graphic when "context.patch_div_s <= 0 or context.patch_div_t <= 0)"
I also change the value to 1 to prevent Indexoutofbound.
(10-08-2012, 01:06 PM)digiadventures Wrote: Cant you add the code directly to google svn so that you version appears on buildbot.orphis.net for example ?
Or do you have to be aproved by gid15 fist ? I dont know how this works ?
RE: Unsupported bezier patches patch_div_s Fix - digiadventures - 10-08-2012
Well I went to google svn and this is what it says:
"How-to: Join this project by contacting the project owners, usually through participating in a mailing list"
So yeah you need to contact gid15 to add you to the list and then you can just change the code and new versions will be automatically made of what ever changes you make on for example buildbot.
In the meantime,can you provide download for this version I want to test something
RE: Unsupported bezier patches patch_div_s Fix - icecoffemix - 10-08-2012
Just create a bug report and attach your tag there, the one responsible for the project will review it and apply it if they find it good enough (i.e. not breaking anything else).
RE: Unsupported bezier patches patch_div_s Fix - sum2012 - 10-08-2012
someone have helped me to create a bug report.
But he don't add these 2 lines
Code:
if (context.patch_div_s < 1){ context.patch_div_s = 1 ;}//change here
if (context.patch_div_t < 1){ context.patch_div_t = 1;}//change hereTo digiadventures
Please test
http://www.mediafire.com/download.php?81ez23g1p9752ay
RE: Unsupported bezier patches patch_div_s Fix - gid15 - 10-09-2012
(10-07-2012, 11:31 PM)sum2012 Wrote:Thank you for your research!Code:VideoEngine.java
private void drawBezier(int ucount, int vcount) {
if ((ucount - 1) % 3 != 0 || (vcount - 1) % 3 != 0) {
log.warn("Unsupported bezier parameters ucount=" + ucount + " vcount=" + vcount);
return;
}
if (context.patch_div_s <= 0 || context.patch_div_t <= 0) {
log.warn("Testing fix for Unsupported bezier patches patch_div_s=" + context.patch_div_s + " patch_div_t=" + context.patch_div_t); //change here
if (context.patch_div_s < 1){ context.patch_div_s = 1 ;}//change here
if (context.patch_div_t < 1){ context.patch_div_t = 1;}//change here
// return; //change here
}
initRendering();
...
Second Novel Kanojo no Natsu 15 fun no Kioku Menu
Rev2758
http://imageshack.us/a/img141/1503/menubad.jpg
Rev2758 fixed version
http://imageshack.us/a/img715/8963/menuok.jpg
Hope apply the offical version.Thanks
Edit:Add log file
I've tested different parameter combinations on a real PSP using the splinesurface demo.
The problem should now be fixed in r2760.
RE: Unsupported bezier patches patch_div_s Fix - sum2012 - 10-09-2012
Yes fixed,thanks you.
Attach R2762 log
(10-09-2012, 04:15 PM)gid15 Wrote: Thank you for your research!
I've tested different parameter combinations on a real PSP using the splinesurface demo.
The problem should now be fixed in r2760.