EmuNewz Network
Bug in scePsmfPlayer r2417 - Printable Version

+- EmuNewz Network (https://www.emunewz.net/forum)
+-- Forum: PSP Emulation (https://www.emunewz.net/forum/forumdisplay.php?fid=191)
+--- Forum: JPCSP Official Forum (https://www.emunewz.net/forum/forumdisplay.php?fid=51)
+---- Forum: svn trunk discussion (https://www.emunewz.net/forum/forumdisplay.php?fid=56)
+---- Thread: Bug in scePsmfPlayer r2417 (/showthread.php?tid=23211)



Bug in scePsmfPlayer r2417 - Itaru - 01-22-2012

Starting with r2417, the opening movie of Final Fantasy IV doesn't play. I've managed to track the bug to the jpcsp.HLE.modules150.scePsmfPlayer class in the annotations. Soywiz added the checkInsideInterrupt attribute to all the methods in that class, but I believe these 6 methods are not supposed to have it:
  • scePsmfPlayerSetPsmfCB
  • scePsmfPlayerUpdate
  • scePsmfPlayerGetCurrentStatus
  • scePsmfPlayerBreak
  • scePsmfPlayerSetPsmfOffset
  • scePsmfPlayerSetPsmfOffsetCB

Removing the checkInsideInterrupt=true attribute for the 6 methods above fixes the movie playing in FFIV.


RE: Bug in scePsmfPlayer r2417 - gid15 - 01-22-2012

Good catch!
Thank you for your detailed review.
This is now fixed in r2449.


RE: Bug in scePsmfPlayer r2417 - Itaru - 01-22-2012

Thanks for the fix, gid15!